[phpBB Debug] PHP Warning: in file [ROOT]/vendor/symfony/filesystem/Filesystem.php on line 232: chown(): Operation not permitted
possible typo in validity.cpp - MAMEDEV Forum
krick
Posts: 2
Joined: Wed Jun 29, 2016 9:24 pm

possible typo in validity.cpp

In the recent commit to validity.cpp, I think there might be a typo in the first line in this function...

Code: Select all

void validity_checker::validate_inlines() { volatile UINT64 testu64a = random_i64(); volatile INT64 testi64a = random_i64(); volatile UINT32 testu32a = random_u32(); volatile UINT32 testu32b = random_u32(); volatile INT32 testi32a = random_i32(); volatile INT32 testi32b = random_i32(); ...
Since the type is UINT64, shouldn't the method called be: random_u64()
The other initializations match their types, that's the only odd one.

User avatar
Tafoid
Posts: 295
Joined: Thu Nov 06, 2014 12:50 pm
Location: USA
Contact: Website

Re: possible typo in validity.cpp

krick wrote:In the recent commit to validity.cpp, I think there might be a typo in the first line in this function...

Code: Select all

void validity_checker::validate_inlines() { volatile UINT64 testu64a = random_i64(); volatile INT64 testi64a = random_i64(); volatile UINT32 testu32a = random_u32(); volatile UINT32 testu32b = random_u32(); volatile INT32 testi32a = random_i32(); volatile INT32 testi32b = random_i32(); ...
Since the type is UINT64, shouldn't the method called be: random_u64()
The other initializations match their types, that's the only odd one.
This appears fixed in current GIT: https://github.com/mamedev/mame/commit/ ... 807e7cb5bc
I'd suggest using the GIT Issues to point out such bleeding edge problems or join us in IRC (freenode - #mame) for more immediate attention in the future as the forum at this time hasn't a whole lot of attention yet.

Return to “MAME Discussion”