I posted a pull request and got a quick response asking for some changes.
I made changes, but it has been sitting for three weeks in review.
Is there something I should be doing to get this reviewed again?
See https://github.com/mamedev/mame/pull/12 ... 1896044929
-
UnclePetros
- Posts: 2
- Joined: Sat Jun 29, 2024 4:34 pm
Re: Pull Request Waiting for Review
Hi mate,
I'm new to the mame contrib world.
Anyway, as software engineer could say, usually reviewers want the pull request to be aligned with main branch version, without conflict.
May be, you can try to get it aligned, and ask again for a merge.
I'm new to the mame contrib world.
Anyway, as software engineer could say, usually reviewers want the pull request to be aligned with main branch version, without conflict.
May be, you can try to get it aligned, and ask again for a merge.